Skip to content

Remove tags prefix #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 19, 2025
Merged

Remove tags prefix #33

merged 4 commits into from
Jun 19, 2025

Conversation

goruha
Copy link
Contributor

@goruha goruha commented Jun 19, 2025 •
edited by coderabbitai bot
Loading

what

  • The change updates the source URL for modules to remove the tags/ prefix in the version reference.

why

  • Terraform handles incorrectly git paths which have slashes in ref parameter

references

Summary by CodeRabbit

  • Chores
    • Updated the reference format for the Datadog Terraform module without changing its version or functionality.
    • Updated the IAM roles module source to a versioned remote GitHub repository for improved module management.
    • Changed the source of the roles-to-principals module to a versioned remote GitHub repository for consistent module sourcing.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 19, 2025 •
edited
Loading

Walkthrough

The Terraform configuration was updated to change the source references for three modules: the Datadog module source URL was modified by removing the "tags/" prefix from the Git version reference, and the iam_roles and roles_to_principals module sources were changed from local relative paths to remote GitHub repository URLs with specific version tags. No other logic or configuration changes were made.

Changes

File(s) Change Summary
src/provider-datadog.tf Removed "tags/" prefix from the Datadog module source URL version reference (from tags/v1.535.2 to v1.535.2).
src/providers.tf, src/main.tf Changed iam_roles and roles_to_principals module sources from local paths to remote GitHub repository URLs with version v1.535.3.

Possibly related PRs

Poem

A tag once stood in the way,
Now the path is clear today.
With "tags/" gone from the source,
Our modules stay the course.
From local paths to GitHub streams,
Terraform flows like hopping dreams!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a417d0 and 7a66963.

📒 Files selected for processing (1)
  • src/main.tf (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/main.tf
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mergify mergify bot requested review from a team June 19, 2025 16:12
@mergify mergify bot added triage Needs triage needs-test Needs testing labels Jun 19, 2025
@mergify Mergify
Copy link

mergify bot commented Jun 19, 2025

💥 This pull request now has conflicts. Could you fix it @goruha? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Jun 19, 2025
@mergify mergify bot removed the conflict This PR has conflicts label Jun 19, 2025
@mergify mergify bot removed the triage Needs triage label Jun 19, 2025
@goruha goruha added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit e6c3754 Jun 19, 2025
14 checks passed
@goruha goruha deleted the remove-tags-prefix branch June 19, 2025 16:33
@github-actions GitHub Actions
Copy link

These changes were released in v1.535.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

Assignees
No one assigned
Labels
needs-test Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goruha @Benbentwo